Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmountHTMLWhenHide not working #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olya777
Copy link

@olya777 olya777 commented Jun 28, 2018

@alex-shatalov
Copy link

+1 waiting

1 similar comment
@yuepywu
Copy link

yuepywu commented Jul 24, 2018

+1 waiting

@ButuzGOL
Copy link

ButuzGOL commented Aug 6, 2018

+1

@modestasmikutis
Copy link

+1 waiting

@PGytis
Copy link

PGytis commented Sep 21, 2018

+1

1 similar comment
@jobalouk
Copy link

+1

@@ -323,7 +323,7 @@ class Tippy {
if (
isVisible(popper) ||
!appendTo.contains(popper) ||
getComputedStyle(tooltip).opacity === '1'
getComputedStyle(tooltip).opacity !== '1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a quick test, your fix seems to make the issue more than fix it, the tooltip in my usual use-case got stuck and never unmount out of DOM.

The original logic seems correct so, again, please help giving more clue / code snippet. Would very appreciate it.

@tuanthieu2993
Copy link
Contributor

Thanks @olya777 for your contribution,

But could you ever reproduce the issue and please post some code snippet here so we could find what is the root cause and make sure our solution could solve it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants